josema/ch93710/fix-wrong-username-error #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus89
requested changes
Sep 4, 2020
There was a problem hiding this comment.
Good approach! However, some things can be improved in the implementation:
- Filter only "not_found" CartoException in the
not_founddecorator. The other CartoExceptions should reach the user - Move the decorator to the context_manager
- Decorate only the carto-python request methods:
…nly NotFoundException subexception
|
Re-CR, please! Yes, the |
Jesus89
reviewed
Sep 4, 2020
| try: | ||
| return func(*args, **kwargs) | ||
|
|
||
| except CartoException as e: |
There was a problem hiding this comment.
I would simplify this to
except NotFoundException:
raise Exception('Resource not found')There was a problem hiding this comment.
That doesn't work :(
The exception is a CartoException, created with a NotFoundException as the only parameter, so we need to inspect the args.
Jesus89
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH issue CARTOframes#1466
CH story ch93719